Fix Linux/Windows Testing support #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Feb 21, 2025
| .library(name: "IssueReportingTestSupport", targets: ["IssueReportingTestSupport"]), | ||
| .library( | ||
| name: "IssueReportingTestSupport", | ||
| type: .dynamic, |
Member
Author
There was a problem hiding this comment.
We need to force this to be dynamic for Linux/Windows to be able to dynamically load its symbols.
stephencelis
commented
Feb 21, 2025
Comment on lines
-48
to
-50
| package.dependencies.append( | ||
| .package(url: "https://github.com/apple/swift-testing", from: "0.11.0") | ||
| ) |
Member
Author
There was a problem hiding this comment.
This was an artifact of early days Testing and was causing problems.
jshier
reviewed
Feb 21, 2025
Member
Author
mbrandonw
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took awhile to track down the issue, but hopefully this is it!